作者:空荡荡跑龙套 | 来源:互联网 | 2024-10-28 10:41
Fixes #1356Changes proposed in this pull request:Drop support for ID in profile urls. Only accept us
Fixes #1356
Changes proposed in this pull request:
Drop support for ID in profile urls. Only accept username.
Reviewers should focus on:
This is based on one of the proposal discussed in the issue. However I'm not sure how to handle errors, as "not found" is now an empty list instead of a native 404.
Also the fact that
is now a list could break some extensions that read the payload directly. I'm thinking of the SEO extension which I have not tested in combination with this.
Confirmed
- [x] Frontend changes: tested on a local Flarum installation.
- [ ] Backend changes: tests are green (run
).
Required changes:
- [ ] Related documentation PR: (Remove if irrelevant)
- [ ] Related core extension PRs: (Remove if irrelevant)
该提问来源于开源项目:flarum/core
I'm closing this for now. I still don't like the approach enough.