作者：Z-RZI | 来源：互联网 | 2023-06-30 15:26
Fixes #1670
Changes proposed in this pull request:
Fixes the position of the composer to the screen, you can test this in https://beta.flarum.site, just make sure you add the relevant CSS from the admin section.
1
2
3
4
5
6
| css
(max-width: 767px) {
.Composer:not(.minimized) {
position: fixed;
}
} |
Reviewers should focus on:
My only concern is that looking at git blame, the composer's position was made absolute in 2015 to fix a bug with iOs 8/9, but there doesn't seem to be any mention of what that bug exactly was, so I cannot tell if this could potentially bring back that bug.
Relevant commit: https://github.com/flarum/core/commit/e6e2cdd3e98be6268f4dd7fb370d366f565ae72e
Screenshot
The issue has images of the bug fixed by this PR.
Confirmed
- ~[ ] Frontend changes: tested on a local Flarum installation.~
- ~[ ] Backend changes: tests are green (run
).~
该提问来源于开源项目：flarum/core
I guess I'm just assuming it would be better if the keyboard hid a part of the composer's bottom, then if the keyboard pushed the composer up to hide it's top :shrug:
京公网安备 11010802041100号